updating the code coverage on more niche syntaxes#1425
Merged
Conversation
Janther
force-pushed
the
ast-coverage
branch
from
edde4b1 to
231e62e
Compare
Janther
force-pushed
the
ast-coverage
branch
2 times, most recently
from
f7df10d to
bac5dbd
Compare
fvictorio
approved these changes
Feb 27, 2026
Janther
force-pushed
the
ast-coverage
branch
from
bac5dbd to
5942f7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was inspired by #1413, which if merged will drop some of the code coverage when instancing a
variantand it won't be so strict.With this, if #1413 is approved, all possible cases would have been covered and we only would need to be diligent when adding new
variants.There was an improvement on the total coverage but mainly the goal was to closely check on every possibility described in Slang's documentation.